Choose fragments over arrays and keys

Amsterdam · Nov 4, 2024 · 1a0106d · 1a0106d
1 parent ae2da82
commit 1a0106d
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/packages/react/src/Button/Button.tsx b/packages/react/src/Button/Button.tsx
@@ -48,16 +48,28 @@ export const Button = forwardRef(
         case !icon:
           return children
         case iconBefore:
-          return [<Icon key={1} svg={icon} size="level-5" />, children]
-        case iconOnly:
-          return [
-            <Icon key={1} svg={icon} size="level-5" square={true} />,
-            <span className="ams-visually-hidden" key={2}>
+          return (
+            <>
+              <Icon svg={icon} size="level-5" />
               {children}
-            </span>,
-          ]
+            </>
+          )
+        case iconOnly:
+          return (
+            <>
+              <Icon svg={icon} size="level-5" square={true} />
+              <span className="ams-visually-hidden" key={2}>
+                {children}
+              </span>
+            </>
+          )
         default:
-          return [children, <Icon key={1} svg={icon} size="level-5" />]
+          return (
+            <>
+              {children}
+              <Icon svg={icon} size="level-5" />
+            </>
+          )
       }
     }