Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deluge-meta.rb to install typing-extensions with pip #26

Closed
wants to merge 2 commits into from

Conversation

2600box
Copy link
Contributor

@2600box 2600box commented Sep 10, 2024

python-typing-extensions was removed from brew, presumably in favour of pip.

https://formulae.brew.sh/formula/python-typing-extensions

Responding to this issue; #23

@Amar1729
Copy link
Owner

Amar1729 commented Sep 10, 2024

Thanks for the PR @2600box ! a few notes:

  • you'll also want to remove the depends_on "python-typing-extensions"
  • is there any reason this dep can't be added as a resource block? (i.e. using homebrew-pypi-poet?) I think that would elide the need for doing a system libexec/pip install manually. (*see below)
  • you can bump the revision to 5
  • you could also remove the caveats section entirely if you like (woo!)

*if you haven't done this before, this is pretty much what i do:

python3.12 -m venv venv
source venv/bin/activate

pip install deluge wheel homebrew-pypi-poet
poet wheel > resources.rb 
poet deluge >> resources.rb

# then i manually copy the content of resources.rb over to the right place in Formula/deluge-meta.rb

ps. make sure to run brew audit deluge-meta, as that's one of the checks the CI will run.

2600box and others added 2 commits September 15, 2024 14:13
- update license to GPL-3.0-only
- update dependencies
- remove python-typing-extensions and install as a resource
- remove caveats block
- bump revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants