Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion for simplified policy #213

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nkylstad
Copy link
Member

Description

I would like to suggest a simplified version of the policy file for new apps. There really is no need to split everything into different rules. It would be much easier to work with the policy with fewer rules, most apps probably do not have super complex needs. Those that do have more complex needs probably have to make a lot of changes to their policy either way, while this simplified version allows those with simple needs to work with the policy easily, by just updating 1 rule.

I have kept the same default roles for now. Open to discussion if we should f.ex. be using some other default role (PRIV f.ex.?) for now. See considerations below for more details on current situation in Studio.

Out of scope, but to be considered at a later point

  • We really should not be shipping with default roles like REGNA and DAGL. Instead, we should omit the roles entirely and inform app developers of the need to consider and decide which role is relevant for them. However, we are not rigged for that just yet. We need some sort of validation that stops the user from publishing a service that does not contain any roles. Once that is done, we can remove the roles entirely from the template.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant