Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My suggested changes to feature/notifications #65

Merged
merged 3 commits into from
Nov 20, 2023
Merged

My suggested changes to feature/notifications #65

merged 3 commits into from
Nov 20, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 17, 2023

Changes in 2 separate commits

  1. a854230 Ensures that all files are equal as in notifications repo and that all files declare #nullable enable (until we can activate it project wide)
  2. 03d7ba0
    • Use #if !LOCALTEST to block out code that needs to be removed for localtest
    • Move files that aren't copied (but custom for localtest) to a separate folder.
    • Rename OrderRepositroy to LocalOrderRepository

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne
Moved notifications files to original folders
a854230 
add #nullable enable to all files
@ivarne
My suggested changes to ensure better separation between copied and l…
03d7ba0 
…ocal code

Allow copied code from core to use #if LOCALTEST

This makes it simpler to maintain (almost) the code in multiple
repositories greatly simplifying maintanance when copying changes.
@ivarne ivarne requested a review from acn-sbuad November 17, 2023 13:53
@acn-sbuad acn-sbuad merged commit 1a861d3 into feature/notifications Nov 20, 2023
1 check passed
@acn-sbuad acn-sbuad deleted the ivarne/feature/notifications branch November 20, 2023 08:30
ivarne added a commit that referenced this pull request Nov 20, 2023
@acn-sbuad @ivarne
notifications funcitonality added #GCPActive (#62)
be99926 
* copied all code

* Added repository logic

* all notifications code in single folder

* Reverted changes to other components

* added readme

* copied with namespace

* added nullable enable

* My suggested changes to feature/notifications (#65)

---------

Co-authored-by: Ivar Nesje <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad Awaiting requested review from acn-sbuad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @acn-sbuad