Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP attributes to actions in HomeController #63

Merged

Conversation

chrrust
Copy link
Contributor

@chrrust chrrust commented Nov 15, 2023

Description

HTTP attributes were missing for actions GetTestUserToken and GetTestOrgToken making them unusable. This PR annotates the actions with HttpGet attribute with a binding to the input parameter so that they can be used again.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@chrrust chrrust force-pushed the chore/fix-http-attributes-in-home-controller branch from 10ec363 to 4d35ee0 Compare November 15, 2023 14:57
@chrrust chrrust changed the title Add HTTP attributes missing action in HomeController Add HTTP attributes to actions in HomeController Nov 15, 2023
@ivarne ivarne self-requested a review November 15, 2023 15:30
Copy link
Member

@ivarne ivarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for catching this so quickly and fixing it. I thought I was smart in
#61, but did not check that all endpoints still works. It's hard when the defaults does not solve your issue anymore and you star overriding and it has consequences in other places.

@ivarne ivarne merged commit 974e636 into Altinn:main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants