Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page for easily finding the Urls for localtest ApiTokens #126

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 23, 2024

I'm tired of answering the question on how to get API tokens in localtest, so now they are available on a separate page.

I did my best to mimic the current design as much as possible.

image

@ivarne ivarne mentioned this pull request Nov 26, 2024
5 tasks
@ivarne ivarne force-pushed the feat/newTokensPage branch from 0b19805 to e39105e Compare November 27, 2024 08:48
@ivarne
Copy link
Member Author

ivarne commented Nov 27, 2024

@martinothamar Updated with a field for the scopes.

Copy link
Contributor

@martinothamar martinothamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we might consider is only adding the org claim when there is a serviceowner scope. I think that's the behavior in Authentication currently

@ivarne
Copy link
Member Author

ivarne commented Nov 27, 2024

Yes, that's probably good, but there are loads of such differences, and I'm not sure this matters.

@ivarne ivarne merged commit d7dc726 into main Nov 27, 2024
4 checks passed
@ivarne ivarne deleted the feat/newTokensPage branch November 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants