Endpoint for fetching current party roles #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhaeger
changed the title
5 tasks
adamhaeger
added
the
feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+218
to
+226
| catch (Exception ex) | ||
| { | ||
| _logger.LogError( | ||
| ex, | ||
| "An error occurred while retrieving roles for userId {UserId} and partyId {PartyId}", | ||
| userId, | ||
| userPartyId | ||
| ); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
| /// <param name="userId">The user id.</param> | ||
| /// <param name="userPartyId">The user party id.</param> | ||
| /// <returns>A list of roles for the user on the specified party.</returns> | ||
| public async Task<List<Role>> GetUserRolesAsync(int userId, int userPartyId) |
There was a problem hiding this comment.
I wonder if we should return IEnumerable<> or IReadOnlyList<> instead, to express the intended usage
| /// <returns>A list of roles for the user on the specified party.</returns> | ||
| public async Task<List<Role>> GetUserRolesAsync(int userId, int userPartyId) | ||
| { | ||
| List<Role> roles = new(); |
There was a problem hiding this comment.
Usually we wrap the body in activity (distributed trace spans). You can probably find example usages of Telemetry
| "An error occurred while retrieving roles for userId {UserId} and partyId {PartyId}", | ||
| userId, | ||
| userPartyId | ||
| ); |
There was a problem hiding this comment.
I'm not sure about the error handling here. If the API fails for some reason we return an empty list, which might make it look like the user has no roles when in fact the problem was that we couldn't find out at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds endpoint for fetching the users current party roles.
You need this PR in localtest to test:
Altinn/app-localtest#131
Description
/api/authorization/rolesto AuthorizationControllerRelated Issue(s)
Verification
Documentation