Fix double save in multipart requests #967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.5 preview versions included this bug where saving was done multiple times which caused there to be created multiple data elements with the same content.
This fixes the issue by moving the saving logic out of the loop of elements to save (which is correct behaviour for DataWriteProcessor), but somewhat changes behaviour in that
IDataWriteProcessor
gets called for all initialisations, also those that have empty change sets.Review with hidden whitespace 😉
Verification
Documentation