Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double save in multipart requests #967

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Dec 10, 2024

8.5 preview versions included this bug where saving was done multiple times which caused there to be created multiple data elements with the same content.

This fixes the issue by moving the saving logic out of the loop of elements to save (which is correct behaviour for DataWriteProcessor), but somewhat changes behaviour in that IDataWriteProcessor gets called for all initialisations, also those that have empty change sets.

Review with hidden whitespace 😉

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne added the bugfix Label Pull requests with bugfix. Used when generation releasenotes label Dec 10, 2024
@ivarne ivarne requested a review from martinothamar December 10, 2024 22:51
Copy link

sonarcloud bot commented Dec 10, 2024

@ivarne ivarne merged commit 383c9e5 into main Dec 11, 2024
14 checks passed
@ivarne ivarne deleted the bug/multipart-double-save branch December 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Label Pull requests with bugfix. Used when generation releasenotes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants