Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR package dep issue #961

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix PR package dep issue #961

merged 1 commit into from
Dec 6, 2024

Conversation

martinothamar
Copy link
Contributor

Description

Couldn't have this part in a target I think, this worked locally (the restore target is probably responsible for getting the right dep package ID)

Related Issue(s)

  • N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

HauklandJ
HauklandJ approved these changes Dec 6, 2024
View reviewed changes
src/Directory.Build.props Show resolved Hide resolved
@martinothamar martinothamar merged commit c8722ad into main Dec 6, 2024
8 of 9 checks passed
@martinothamar martinothamar deleted the fix/pr-package-dep-issue2 branch December 6, 2024 13:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HauklandJ HauklandJ HauklandJ approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinothamar @HauklandJ