Run analyzers that sonar cloud runs

[ivarne]

This enables analysers that Sonar Cloud runs so that they can be caught in local development instead of the slow cycle of getting an issue in sonar cloud.

This is part of #730, because I changed these to warning in .editorconfig because it made the sonar cloud issues easier to find. I think this could be reviewed separately.

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[martinothamar]

nice! are you adding SonarAnalyzer.CSharp as well or is this just about catching builtin warnings that sonar also complains about?

[ivarne]

No, I just took the ones that seemed to be available with a code.

I’m not sure about the static if you don’t access class variables thing. It doesn’t always seem like an improvement to differentiate methods that write telemetry with a static modifier.

[ivarne]

This is part of #730, and I seem to have not fixed all warnings here.