Feature/subform #743
Closed
Feature/subform #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… various tests and minor issues
…before CreateAppModelData call
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -316,11 +324,12 @@ | |||
|
|
|||
| if (dataType is null) | |||
| { | |||
| string error = $"Could not determine if {dataType} requires app logic for application {org}/{app}"; | |||
| var error = $"Could not determine if {dataType} requires app logic for application {org}/{app}"; | |||
Check warning
Code scanning / CodeQL
Use of default ToString() Warning
There was a problem hiding this comment.
Takk CodeQL. Gir ikke mye mening å logge ... determine if null requires ...
Suggested change
| var error = $"Could not determine if {dataType} requires app logic for application {org}/{app}"; | |
| var error = $"Could not determine if {dataElement.DataType} requires app logic for application {org}/{app}"; |
|
|
This is now merged into #730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See Altinn/app-frontend-react#2137.
Related Issue(s)
Verification
Documentation