Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdf and eFormidling as service tasks. #731

Closed
wants to merge 1 commit into from
Closed

Conversation

bjorntore
Copy link
Contributor

@bjorntore bjorntore commented Aug 20, 2024

Implementing basic support for service task in bpmn.

Moving PDF and eFormidling into service tasks, but also keep legacy implementations and old way of configuring for backwards compatibility for now.

image

Draft state. Very open for discussions. Still working on unit and integration tests, and likely have to make adjustments after frontend starts implementing matching support.

Description

  • Service task inherits from Task and behaves in the same way in most cases, except it also has an abstract method called Execute which must be implemented.
  • No refactoring of process engine in general here.
    <bpmn:task id="Task_1" name="Utfylling">
      <bpmn:incoming>SequenceFlow_1n56yn5</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_1oot28q</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>data</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:task>
    <bpmn:serviceTask id="Task_2" name="PDF">
        <bpmn:incoming>SequenceFlow_1oot28q</bpmn:incoming>
        <bpmn:outgoing>SequenceFlow_4ooasd</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>pdf</altinn:taskType>
          <altinn:pdfConfig>
            <altinn:filename>some.text.resource.binding</altinn:filename>
            <altinn:tasksToIncludeInPdf>
              <altinn:task>Task_1</altinn:task>
            </altinn:tasksToIncludeInPdf>
          </altinn:pdfConfig>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>
    <bpmn:serviceTask id="Task_3" name="eFormidling">
      <bpmn:incoming>SequenceFlow_4ooasd</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_5assd2s</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>eFormidling</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@bjorntore bjorntore self-assigned this Aug 20, 2024
@bjorntore bjorntore force-pushed the feat/pdf-service-task branch from d1c9129 to bc7ca62 Compare August 20, 2024 09:21
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 65%)
25.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@bjorntore bjorntore closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant