Remove dead code

Altinn · Jan 4, 2024 · 92bc3f9 · 92bc3f9
1 parent 698500c
commit 92bc3f9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 21 deletions.
diff --git a/src/Altinn.App.Core/Features/Validation/Default/DataAnnotationValidator.cs b/src/Altinn.App.Core/Features/Validation/Default/DataAnnotationValidator.cs
@@ -32,15 +32,10 @@ public DataAnnotationValidator(IHttpContextAccessor httpContextAccessor, IObject
     }
 
     /// <summary>
-    /// Dummy implementation to satisfy interface, We use <see cref="CanValidateDataType" /> instead
+    /// Run Data annotation validation on all data types with app logic
     /// </summary>
     public string DataType => "*";
 
-    /// <summary>
-    /// Run validator for all data types.
-    /// </summary>
-    public bool CanValidateDataType(string dataType) => true;
-
     /// <summary>
     /// Disable incremental validation for this validator.
     /// </summary>

diff --git a/src/Altinn.App.Core/Features/Validation/Default/DefaultDataElementValidator.cs b/src/Altinn.App.Core/Features/Validation/Default/DefaultDataElementValidator.cs
@@ -9,13 +9,10 @@ namespace Altinn.App.Core.Features.Validation.Default;
 /// </summary>
 public class DefaultDataElementValidator : IDataElementValidator
 {
-    /// <inheritdoc />
-    public string DataType => "*";
-
     /// <summary>
-    /// Runs on all data elements to validate metadata and file scan results.
+    /// Run validations on all data elements
     /// </summary>
-    public bool CanValidateDataType(DataType dataType) => true;
+    public string DataType => "*";
 
     /// <inheritdoc />
     public Task<List<ValidationIssue>> ValidateDataElement(Instance instance, DataElement dataElement, DataType dataType)

diff --git a/test/Altinn.App.Core.Tests/Features/Validators/Default/DataAnnotationValidatorTests.cs b/test/Altinn.App.Core.Tests/Features/Validators/Default/DataAnnotationValidatorTests.cs
@@ -49,16 +49,6 @@ private class TestClass
         public TestClass? NestedProperty { get; set; }
     }
 
-    [Fact]
-    public void CanValidateDataType()
-    {
-        // Act
-        var result = _validator.CanValidateDataType(DataAnnotationsTestFixture.DataType);
-
-        // Assert
-        Assert.True(result);
-    }
-
     [Fact]
     public void ShouldRunForIncrementalValidation()
     {