Remove unused property on DataPatchResult (#852)

Altinn · Oct 22, 2024 · 06c39a4 · 06c39a4
1 parent 209f36f
commit 06c39a4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/src/Altinn.App.Core/Internal/Patch/DataPatchResult.cs b/src/Altinn.App.Core/Internal/Patch/DataPatchResult.cs
@@ -1,4 +1,3 @@
-using Altinn.App.Core.Features;
 using Altinn.App.Core.Models;
 using Altinn.App.Core.Models.Validation;
 using Altinn.Platform.Storage.Interface.Models;
@@ -20,11 +19,6 @@ public class DataPatchResult
     /// </summary>
     public required List<ValidationSourcePair> ValidationIssues { get; init; }
 
-    /// <summary>
-    /// The current data model after the patch operation.
-    /// </summary>
-    public required List<DataElementChange> ChangedDataElements { get; init; }
-
     /// <summary>
     /// Get updated data elements that have app logic in a dictionary with the data element id as key.
     /// </summary>

diff --git a/src/Altinn.App.Core/Internal/Patch/PatchService.cs b/src/Altinn.App.Core/Internal/Patch/PatchService.cs
@@ -197,7 +197,6 @@ await RunDataProcessors(
         return new DataPatchResult
         {
             Instance = instance,
-            ChangedDataElements = changes,
             UpdatedData = updatedData,
             ValidationIssues = validationIssues,
         };

diff --git a/test/Altinn.App.Core.Tests/Internal/Patch/PatchServiceTests.cs b/test/Altinn.App.Core.Tests/Internal/Patch/PatchServiceTests.cs
@@ -174,13 +174,13 @@ public async Task Test_Ok()
         response.Ok.Should().NotBeNull();
         var res = response.Ok!;
         var change = res
-            .ChangedDataElements.Should()
+            .UpdatedData.Should()
             .ContainSingle()
             .Which.Should()
-            .BeOfType<DataElementChange>()
+            .BeOfType<DataPatchResult.DataModelPair>()
             .Which;
-        change.DataElement.Id.Should().Be(_dataGuid.ToString());
-        change.CurrentFormData.Should().BeOfType<MyModel>().Subject.Name.Should().Be("Test Testesen");
+        change.Identifier.Id.Should().Be(_dataGuid.ToString());
+        change.Data.Should().BeOfType<MyModel>().Subject.Name.Should().Be("Test Testesen");
         var validator = res.ValidationIssues.Should().ContainSingle().Which;
         validator.Source.Should().Be("formDataValidator");
         var issue = validator.Issues.Should().ContainSingle().Which;