Adding cypress test for new attachment API + fixes #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 13, 2024 08:58
…nstance data, the attachments should be considered to be deleted.
…t in the node hierarchy. This makes sure we also update the IDs if an attachment is deleted on the backend (when the backend aldo doesn't update that field in the data model).
…, as attachments don't always map themselves when added to the instance data.
|
bjosttveit
reviewed
Dec 17, 2024
Comment on lines
+593
to
+594
| * If the attachment is deleted from the instance data outside of these functions (i.e. by a backend hook), these | ||
| * components will make sure to remove the attachment ID from the data model: |
There was a problem hiding this comment.
Good catch, I did not think of this case 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I tested the functionality implemented in #2754, I found two problems:
useNodeAttachments()that carries over previously-seen attachments also did that for successful uploads, but the comment indicated it was only supposed to happen for uploads in progress.Maintain*DataModelBindingcomponents to make sure we update those values when instance data elements disappear.Also adding a cypress test for this functionality, with a somewhat hidden test structure and quite strange
IDataWriteProcessorin thettd/subformapp.Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping