Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/person lookup #2723

Merged
merged 33 commits into from
Dec 4, 2024
Merged

Feature/person lookup #2723

merged 33 commits into from
Dec 4, 2024

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Nov 15, 2024

Description

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida changed the base branch from main to feature/button November 15, 2024 15:25
@cammiida cammiida added the kind/product-feature Pull requests containing new features label Nov 15, 2024
Base automatically changed from feature/button to main November 18, 2024 11:12
@cammiida cammiida force-pushed the feature/person-lookup branch from 94cf242 to ec21f3f Compare November 19, 2024 13:01
@cammiida cammiida changed the base branch from main to chore/extract-label-type-from-label November 21, 2024 12:01
@HauklandJ HauklandJ force-pushed the feature/person-lookup branch from ec21f3f to 211c9cf Compare November 21, 2024 12:02
@cammiida cammiida force-pushed the chore/extract-label-type-from-label branch from 72be8f2 to e0e79a9 Compare November 21, 2024 14:55
Base automatically changed from chore/extract-label-type-from-label to main November 22, 2024 09:13
@HauklandJ HauklandJ force-pushed the feature/person-lookup branch 2 times, most recently from 708be34 to 9852e13 Compare November 22, 2024 11:56
@HauklandJ HauklandJ marked this pull request as ready for review November 25, 2024 14:33
Copy link
Contributor Author

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌔

Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.6% Coverage on New Code (required ≥ 45%)
3.0% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@HauklandJ HauklandJ merged commit cee2223 into main Dec 4, 2024
13 of 14 checks passed
@HauklandJ HauklandJ deleted the feature/person-lookup branch December 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Person search component
2 participants