Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource-adm): add temp icons for access packages #14347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Jan 3, 2025

Description

Add correct icons for access packages. These icon files are temporary checked in; later these icons will be loaded from the access package metadata API.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. area/authorization Area: Issues related to roles and rights on apps, such as who can instantiate, sign etc. frontend labels Jan 3, 2025
@mgunnerud mgunnerud changed the title feat(resour) :add temp icons for access packages feat(resource-adm): add temp icons for access packages Jan 3, 2025
@mgunnerud mgunnerud added skip-releasenotes Issues that do not make sense to list in our release notes skip-manual-testing PRs that do not need to be tested manually labels Jan 3, 2025
@mgunnerud mgunnerud requested a review from wrt95 January 3, 2025 09:07
@mgunnerud mgunnerud marked this pull request as ready for review January 3, 2025 09:07
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (e49c545) to head (120c710).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14347   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files        1858     1859    +1     
  Lines       24048    24070   +22     
  Branches     2773     2774    +1     
=======================================
+ Hits        22990    23012   +22     
  Misses        800      800           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authorization Area: Issues related to roles and rights on apps, such as who can instantiate, sign etc. frontend skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant