Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subform): Add GET and PUT endpoints for datamodel metadata #14275

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Dec 12, 2024

Description

  • Backend endpoints to update metadata/datatype for a datamodel.
  • SchemaModelServiceTests refactored to setup service correctly after changes to SchemaModelService's constructor

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Dec 12, 2024
@Jondyr Jondyr changed the title Add GET and PUT endpoints for datamodel metadata feat(subform): Add GET and PUT endpoints for datamodel metadata Dec 12, 2024
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Dec 12, 2024
@Jondyr Jondyr force-pushed the 12-12-backend_endpoints_for_datamodel_metadata branch from fe7279e to 3fa946f Compare December 12, 2024 13:33
@Jondyr Jondyr added team/studio-domain1 team/studio-domain2 area/data-modeling Area: Related to data models - e.g. create, edit, use data models. and removed quality/testing Tests that are missing, needs to be created or could be improved. labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (c6690b7) to head (2ba50f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14275   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files        1826     1826           
  Lines       23786    23786           
  Branches     2757     2757           
=======================================
  Hits        22720    22720           
  Misses        808      808           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Dec 12, 2024
@Jondyr Jondyr marked this pull request as ready for review December 12, 2024 14:00
@Jondyr Jondyr force-pushed the 12-12-backend_endpoints_for_datamodel_metadata branch from f8f1603 to 92fa272 Compare December 12, 2024 21:16
@Jondyr Jondyr force-pushed the 12-12-backend_endpoints_for_datamodel_metadata branch from 92fa272 to 2ba50f4 Compare December 13, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. backend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1 team/studio-domain2
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

1 participant