chore: 14263 create studio status radio group #14272
Open
+321
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
wrt95
commented
Dec 12, 2024
| const user = userEvent.setup(); | ||
| renderStudioStatusRadioGroup(); | ||
|
|
||
| const successRadioButton = screen.getByRole('radio', { name: `${mockTitle1} ${mockText1}` }); // Any way to do it without having both title and text? |
There was a problem hiding this comment.
@framitdavid, do you have a better suggestion here? 🤔
wrt95
commented
Dec 12, 2024
| await user.click(infoRadioButton); | ||
|
|
||
| expect(mockOnChange).toHaveBeenCalledWith(mockValue2); | ||
| expect(mockOnChange).toHaveBeenCalledTimes(2); // Why is this being called twice? |
There was a problem hiding this comment.
@framitdavid, do you have a suggestion here? 🤔
wrt95
added
team/studio-core
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14272 +/- ##
=======================================
Coverage 95.52% 95.53%
=======================================
Files 1826 1828 +2
Lines 23757 23773 +16
Branches 2752 2753 +1
=======================================
+ Hits 22695 22711 +16
Misses 807 807
Partials 255 255 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skjermopptak.2024-12-12.kl.12.49.42.mov
Related Issue(s)
Verification