fix: automatically open new subform table column in edit mode #14268
+68
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
lassopicasso
added
team/studio-domain2
skip-releasenotes
lassopicasso
changed the title
lassopicasso
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14268 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 1829 1829
Lines 23775 23778 +3
Branches 2754 2754
=======================================
+ Hits 22710 22714 +4
Misses 807 807
+ Partials 258 257 -1 ☔ View full report in Codecov by Sentry. |
lassopicasso
changed the title
lassopicasso
added
the
skip-documentation
| @@ -12,19 +12,21 @@ export type ColumnElementProps = { | |||
| layoutSetName: string; | |||
| tableColumn: TableColumn; | |||
| columnNumber: number; | |||
| initialOpenForEdit: boolean; | |||
There was a problem hiding this comment.
What about changing the name to isColumnInitiallyEditable or isInitialOpenForEdit
There was a problem hiding this comment.
Thx! I will use one of your suggestions :)
| @@ -111,6 +112,18 @@ describe('ColumnElement', () => { | |||
|
|
|||
| expect(onDeleteColumnMock).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Here maybe we can add test or update this to test the scenario where the user clicks first on the button Legg til kolonne and check if the edit mode is showing.
There was a problem hiding this comment.
I agree! :) Nice suggestion!
JamalAlabdullah
requested changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user adds a new column to the subform table, it should automatically open in edit mode, eliminating the need for an additional click. The same behavior can be seen in Prosess page when adding "handling" for a task.
initially-open-edit-mode.mp4
Related Issue(s)
Verification
Documentation