Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update layout set list when adding a new subform #14254

Merged

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Dec 10, 2024

Description

  • Added some missing invalidateQueries for QueryKey.LayoutSetsExtended to ensure the layout set list updates correctly when adding a new subform
  • Refactored SyncSuccessQueriesInvalidator functions to invalidate multiple queries with different query keys

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@mlqn mlqn linked an issue Dec 10, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 10, 2024
@mlqn mlqn changed the title fix: Update layout set lists when adding a new subform fix: Update layout set list when adding a new subform Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (afcae3c) to head (63bd2ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14254   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files        1826     1826           
  Lines       23780    23786    +6     
  Branches     2757     2757           
=======================================
+ Hits        22714    22720    +6     
  Misses        808      808           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn marked this pull request as ready for review December 11, 2024 08:10
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! iI works fine

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected :)

@lassopicasso lassopicasso merged commit c6690b7 into main Dec 13, 2024
10 checks passed
@lassopicasso lassopicasso deleted the 14249-the-new-subform-is-missing-from-the-layout-sets-list branch December 13, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new subform is missing from the layout sets list
3 participants