Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add text resource picker to input table #14217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Nov 29, 2024

Description

Added a compound component built on StudioTextResourceInput in StudioInputTable. It can be used in JSX as <StudioInputTable.Cell.TextResource> with the same props as StudioTextResourceInput.

image

Related Issue

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 29, 2024
@TomasEng TomasEng changed the title Add text resource picker to input table feat: Add text resource picker to input table Nov 29, 2024
@TomasEng TomasEng force-pushed the add-text-resource-selector-to-input-table branch from 21e4e04 to 9a852e1 Compare November 29, 2024 14:26
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (2345ba1) to head (98ce4f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14217   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files        1829     1831    +2     
  Lines       23775    23818   +43     
  Branches     2754     2758    +4     
=======================================
+ Hits        22710    22753   +43     
  Misses        807      807           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review December 2, 2024 07:15
@TomasEng TomasEng added team/studio-domain1 skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

1 participant