Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace altinn confirm dialog with studio components #14197

Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 27, 2024

Description

  • Clean up the code by splitting to smaller components and removing wrong imports

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 changed the title Refactor replace altinn confirm dialog with studio components refactor: replace altinn confirm dialog with studio components Nov 27, 2024
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Nov 27, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (2ab780b) to head (2cb7ddf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14197   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files        1819     1824    +5     
  Lines       23722    23745   +23     
  Branches     2750     2751    +1     
=======================================
+ Hits        22662    22684   +22     
  Misses        807      807           
- Partials      253      254    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. 😊

@framitdavid framitdavid removed their assignment Dec 9, 2024
@framitdavid
Copy link
Collaborator

tested ok

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Dec 9, 2024
@framitdavid framitdavid merged commit bf8df32 into main Dec 9, 2024
18 checks passed
@framitdavid framitdavid deleted the refactor--replace-AltinnConfirmDialog-with-studio-components branch December 9, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants