Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove help texts in other settings #14196

Merged
merged 7 commits into from
Dec 8, 2024
Merged

style: remove help texts in other settings #14196

merged 7 commits into from
Dec 8, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Nov 27, 2024 •
edited
Loading

Description

Removes the help text icon for boolean switches in "Andre Innstillinger" config.

image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 27, 2024
@lassopicasso lassopicasso changed the title remove help texts in other settings style: remove help texts in other settings Nov 27, 2024
@lassopicasso lassopicasso linked an issue Nov 27, 2024 that may be closed by this pull request
Remove the question marks and associated English help texts for the general switches in the Andre innstillinger panel #14161
Closed
@lassopicasso lassopicasso marked this pull request as ready for review November 27, 2024 13:38
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (6e309a8) to head (650001f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14196   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files        1809     1810    +1     
  Lines       23571    23580    +9     
  Branches     2725     2726    +1     
=======================================
+ Hits        22513    22522    +9     
  Misses        806      806           
  Partials      252      252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso requested a review from mlqn November 29, 2024 12:28
mlqn
mlqn approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

frontend/packages/ux-editor/src/components/config/editModal/EditBooleanValue.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/hooks/useComponentPropertyHelpText.ts Outdated Show resolved Hide resolved
JamalAlabdullah
JamalAlabdullah approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev

@JamalAlabdullah JamalAlabdullah merged commit a5cb81b into main Dec 8, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the remove-help-texts-in-other-settings branch December 8, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

@mlqn mlqn mlqn approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
3 participants
@lassopicasso @mlqn @JamalAlabdullah