Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove featureflag multiple data models per task #14171

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Nov 26, 2024

Description

This PR removes the feature flag: 'multipleDataModelsPerTask and the code related to this + updates tests.

What should be tested before merging this to main

Pre-Test Setup

  1. Navigate to the Datamodell page
  2. Create and generate several data models with distinct data model fields
  3. Navigate to the Prosesser page
  4. Create a new layoutset and bind it to a data model so it has a default data model

Test cases

  1. Default data model binding for layout set
    a. Create a new layout set i prosesser
    b. Bind the layout set to a default data model
    c. Go to “Utforming” section and add a component
    d. Verify that the default data model is selected in the data model bindings for the component.

  2. Select an Alternative Data Model in Data Model Bindings
    a. Confirm that you can select a data model other than the default in the data model bindings for a component.

  3. Switch between data models in data model bindings
    a. Test switching between different data models in the data model bindings for a component
    b. Ensure the related data model fields are displayed correctly in the dropdown list for each selection.

  4. Preview Functionality with non-default data models
    a. Verify that the preview functionality works as expected when a data model other than the default is selected.
    b. See releated issue: Preview Fails When Linking Component to Non-Default Data Model #14104

  5. Layout configuration – correct bindings displayed
    a. In the layout configuration in “se siste endringer”:
    i. Check that the correct bindings are displayed when selecting data model fields for the default data model
    ii. Check that the correct bindings are displayed when selecting a non-default data model and one of its data model fields

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso linked an issue Nov 26, 2024 that may be closed by this pull request
8 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. frontend labels Nov 26, 2024
@lassopicasso lassopicasso changed the title Remove featureflag multiple data models per task feat: Remove featureflag multiple data models per task Nov 26, 2024
@lassopicasso lassopicasso marked this pull request as ready for review November 26, 2024 15:18
@lassopicasso
Copy link
Contributor Author

lassopicasso commented Nov 26, 2024

This may need to be set to blocked after review until this is solved #14104, to make sure that number 4 works,Preview Functionality with non-default data models.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (37d92b5) to head (417f66a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14171      +/-   ##
==========================================
- Coverage   95.52%   95.52%   -0.01%     
==========================================
  Files        1826     1826              
  Lines       23757    23753       -4     
  Branches     2752     2750       -2     
==========================================
- Hits        22695    22691       -4     
  Misses        807      807              
  Partials      255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀 I just left suggestions to remove some console.log.

frontend/packages/ux-editor/src/utils/component.ts Outdated Show resolved Hide resolved
@lassopicasso
Copy link
Contributor Author

lassopicasso commented Dec 12, 2024

Nice work! 🚀 I just left suggestions to remove some console.log.

Thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove featureflag for multiple data models
2 participants