feat: Delete all Summary 2.0 components that has a reference to deleted component #14126
Conversation
github-actions
bot
added
solution/studio/designer
…elete-all-summary-20-components-that-has-a-reference-to-deleted-element-component-page-or-layout-set
github-actions
bot
added
the
quality/testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| string layout = TestDataHelper.GetFileFromRepo(org, app, developer, $" App/ui/{layoutSetName}/layouts/{layoutName}.json"); | ||
| JsonNode layoutWithDeletedComponent = JsonNode.Parse(layout); | ||
| JsonArray layoutArray = layoutWithDeletedComponent["data"]["layout"] as JsonArray; | ||
| layoutArray.RemoveAt(0); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14126 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 1797 1797
Lines 23367 23367
Branches 2703 2703
=======================================
Hits 22284 22284
Misses 836 836
Partials 247 247 ☔ View full report in Codecov by Sentry. |
| foreach (JsonNode component in layoutArray) | ||
| { | ||
| string deletedId = component["id"]?.GetValue<string>(); | ||
| deletedIds.Add(new Reference("component", notification.LayoutSetName, deletedId)); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
| @@ -20,54 +20,35 @@ | |||
| notification.EditingContext.Repo, | |||
| notification.EditingContext.Developer); | |||
|
|
|||
| string[] layoutSetNames = altinnAppGitRepository.GetLayoutSetNames(); | |||
| LayoutSets layoutSets = await altinnAppGitRepository.GetLayoutSetsFile(cancellationToken); | |||
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| foreach (JsonNode component in layoutArray) | ||
| { | ||
| string deletedId = component["id"]?.GetValue<string>(); | ||
| referencesToDelete.Add(new Reference("component", notification.LayoutSetName, deletedId)); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
Description
Delete all Summary 2.0 components that has a reference to deleted component
Related Issue(s)
Verification