Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use gitRepoMethods to move files/dirs in appGitRepo #14113

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: use gitRepoMethods to move files/dirs in appGitRepo #14113

merged 1 commit into from
Nov 20, 2024

Conversation

standeren
Copy link
Contributor

Description

Making logic for moving files and folders in GitRepository.cs more general and use the general methods in AppGitRepository.cs with the specific file- and folder-names.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@standeren standeren changed the title use gitRepoMethods to move files/dirs in appGitRepo fix: use gitRepoMethods to move files/dirs in appGitRepo Nov 20, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 20, 2024
mirkoSekulic
mirkoSekulic approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@mirkoSekulic mirkoSekulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Nov 20, 2024
@standeren standeren merged commit 8f11d67 into main Nov 20, 2024
15 checks passed
@standeren standeren deleted the generalize-move-file-methods branch November 20, 2024 08:56
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@standeren @nkylstad
fix: use gitRepoMethods to move files/dirs in appGitRepo (#14113)
2d0fd9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@mirkoSekulic mirkoSekulic mirkoSekulic approved these changes

Assignees
No one assigned
Labels
backend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@standeren @mirkoSekulic