Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed empty data model bindings #14101

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: Fixed empty data model bindings #14101

merged 1 commit into from
Nov 20, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Nov 18, 2024 •
edited
Loading

Description

Fixed empty data model bindings

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@mlqn mlqn linked an issue Nov 18, 2024 that may be closed by this pull request
Empty data model bindings #14082
Closed
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 18, 2024
@mlqn mlqn changed the title fix: Fix useValidDataModels fix: Fixed empty data model bindings Nov 18, 2024
@mlqn mlqn force-pushed the 14082-empty-data-model-bindings branch from 5edcd66 to 59522fc Compare November 18, 2024 15:24
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (5b21dae) to head (aa992cd).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14101   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files        1753     1753           
  Lines       22964    22964           
  Branches     2673     2673           
=======================================
  Hits        21885    21885           
  Misses        832      832           
  Partials      247      247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@mlqn mlqn force-pushed the 14082-empty-data-model-bindings branch from 59522fc to aa992cd Compare November 18, 2024 16:00
@mlqn mlqn marked this pull request as ready for review November 18, 2024 16:17
lassopicasso
lassopicasso approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@lassopicasso lassopicasso mentioned this pull request Nov 19, 2024
Closed
4 tasks
Jondyr
Jondyr approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍

@Jondyr Jondyr merged commit d362ec2 into main Nov 20, 2024
17 checks passed
@Jondyr Jondyr deleted the 14082-empty-data-model-bindings branch November 20, 2024 09:33
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@mlqn @nkylstad
fix: Fixed empty data model bindings (#14101)
a96c8e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassopicasso lassopicasso lassopicasso approved these changes

@Jondyr Jondyr Jondyr approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty data model bindings
3 participants
@mlqn @Jondyr @lassopicasso