-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace convert-type-suggestion with cannot-convert-type-message in schemaInspector #14055
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14055 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 1763 1764 +1
Lines 23000 23020 +20
Branches 2676 2678 +2
=======================================
+ Hits 21915 21935 +20
Misses 836 836
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
7f80d66
to
06e6e85
Compare
06e6e85
to
1814774
Compare
Jeg ser det er noen endringer her som ikke er relatert til å endre meldingen. Kunne du flyttet dette ut av PR-en? Det er en del årsaker til at den overskriften ser ut som den gjør, blant annet at den skal ha visuelle fellestrekk med de andre nodene for å gjøre det tydelig at den også er en node i seg selv. Hvis du mener at det er ting som kan forbedres der, bør vi kanskje gjennomføre et arbeidsmøte for å finne en god løsning? |
Kan skille det ut ja. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fin forbedring av datamodellsiden 😊
frontend/packages/schema-editor/src/components/SchemaInspector/SchemaInspector.tsx
Show resolved
Hide resolved
frontend/packages/schema-editor/src/components/SchemaInspector/SchemaInspector.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
… in schemaInspector (#14055)
Description
DEV:
Skjermopptak.2024-11-14.kl.07.25.16.mov
This branch:
Skjermopptak.2024-11-14.kl.08.23.34.mov
Additional changes
Related Issue(s)
Verification