Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace convert-type-suggestion with cannot-convert-type-message in schemaInspector #14055

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Nov 14, 2024

Description

DEV:

Skjermopptak.2024-11-14.kl.07.25.16.mov

This branch:

Skjermopptak.2024-11-14.kl.08.23.34.mov

Additional changes

  • Removed the collapsed property on the resizable layout fraction in schemaInspector to avoid the jumping feeling when going from not having a selected node to selecting a node.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 14, 2024
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-documentation Issues where updating documentation is not relevant labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (4d8c7e3) to head (d86d100).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14055   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files        1763     1764    +1     
  Lines       23000    23020   +20     
  Branches     2676     2678    +2     
=======================================
+ Hits        21915    21935   +20     
  Misses        836      836           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@standeren standeren force-pushed the fix/remove-convert-type-suggestion branch from 7f80d66 to 06e6e85 Compare November 14, 2024 07:22
@standeren standeren changed the title fix: remove convert-type-suggestion in schemaInspector fix: @standeren Replace convert-type-suggestion with cannot-convert-type-message in schemaInspector Nov 14, 2024
@standeren standeren changed the title fix: @standeren Replace convert-type-suggestion with cannot-convert-type-message in schemaInspector fix: replace convert-type-suggestion with cannot-convert-type-message in schemaInspector Nov 14, 2024
@standeren standeren force-pushed the fix/remove-convert-type-suggestion branch from 06e6e85 to 1814774 Compare November 14, 2024 07:32
@TomasEng
Copy link
Contributor

Jeg ser det er noen endringer her som ikke er relatert til å endre meldingen. Kunne du flyttet dette ut av PR-en? Det er en del årsaker til at den overskriften ser ut som den gjør, blant annet at den skal ha visuelle fellestrekk med de andre nodene for å gjøre det tydelig at den også er en node i seg selv. Hvis du mener at det er ting som kan forbedres der, bør vi kanskje gjennomføre et arbeidsmøte for å finne en god løsning?

@standeren
Copy link
Contributor Author

Jeg ser det er noen endringer her som ikke er relatert til å endre meldingen. Kunne du flyttet dette ut av PR-en? Det er en del årsaker til at den overskriften ser ut som den gjør, blant annet at den skal ha visuelle fellestrekk med de andre nodene for å gjøre det tydelig at den også er en node i seg selv. Hvis du mener at det er ting som kan forbedres der, bør vi kanskje gjennomføre et arbeidsmøte for å finne en god løsning?

Kan skille det ut ja.
Jeg så ikke at den skulle ligne de andre nodene - den har jo ikke samme border eller farge fra før heller 🤔
Og jeg tenker umiddelbart at den er lik nok en node ved at den har objektikonet der, men vi kan godt ta en runde på det! 😄

@ErlingHauan ErlingHauan self-assigned this Nov 19, 2024
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fin forbedring av datamodellsiden 😊

@standeren standeren assigned ErlingHauan and unassigned standeren Nov 19, 2024
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

@Konrad-Simso Konrad-Simso merged commit 95c8ca9 into main Nov 22, 2024
16 checks passed
@Konrad-Simso Konrad-Simso deleted the fix/remove-convert-type-suggestion branch November 22, 2024 14:11
@Konrad-Simso Konrad-Simso removed their assignment Nov 22, 2024
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants