-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render StudioCodeListEditor inside each code list accordion #14054
feat: render StudioCodeListEditor inside each code list accordion #14054
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14054 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 1811 1811
Lines 23578 23583 +5
Branches 2733 2733
=======================================
+ Hits 22519 22524 +5
Misses 805 805
Partials 254 254 ☔ View full report in Codecov by Sentry. |
1bf8a6e
to
d57dd30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veldig fin størrelse på denne kodeendringen. Fortsett slik!
...o-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeLists/CodeLists.test.tsx
Outdated
Show resolved
Hide resolved
...studio-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeLists/CodeLists.tsx
Outdated
Show resolved
Hide resolved
...ontent-library/src/ContentLibrary/LibraryBody/pages/CodeList/hooks/useCodeListEditorTexts.ts
Outdated
Show resolved
Hide resolved
...o-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeLists/CodeLists.test.tsx
Outdated
Show resolved
Hide resolved
...o-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeLists/CodeLists.test.tsx
Show resolved
Hide resolved
…sts-in-the-content-library
...studio-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeLists/CodeLists.tsx
Outdated
Show resolved
Hide resolved
…sts-in-the-content-library
efd46f2
to
f79119e
Compare
…sts-in-the-content-library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
Fungerer veldig fint!
Jeg la merke til to ting:
- Av og til lugger det litt når man skriver. Men det vil nok bli fikset når feat: merge select and edit tabs in config #14137, som endrer lagring til
onBlur
, flettes inn i main. - Avsnitteksten i
StudioCodeListEditor
er ganske stor i forhold til overskriftene til akkordionene. Jeg tror det løses best ved å endre tekststørrelsen iStudioCodeListEditor
framedium
tilsmall
.
Før
Etter
Takk for testing 💯 Bra sett at det var størrelseforskjell på teksten - legger til |
Description
Replace placeholder with information that editing will come with
StudioCodeListEditor
implementation.Might need to add
useDebounce
in the onChange fromStudioCodeListEditor
.NB: This PR will not trigger the actual updateOptionList mutation in app-development. This is implemented by another PR
Related Issue(s)
Verification