Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render StudioCodeListEditor inside each code list accordion #14054

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Nov 13, 2024

Description

Replace placeholder with information that editing will come with StudioCodeListEditor implementation.

Might need to add useDebounce in the onChange from StudioCodeListEditor.

Skjermbilde 2024-11-13 kl  15 52 54

NB: This PR will not trigger the actual updateOptionList mutation in app-development. This is implemented by another PR

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Nov 13, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 13, 2024
@standeren standeren changed the title Render StudioCodeListEditor inside each code list accordion feat: render StudioCodeListEditor inside each code list accordion Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (c57f03f) to head (683b062).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14054   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files        1811     1811           
  Lines       23578    23583    +5     
  Branches     2733     2733           
=======================================
+ Hits        22519    22524    +5     
  Misses        805      805           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the 13949-possibility-to-edit-individual-code-lists-in-the-content-library branch from 1bf8a6e to d57dd30 Compare November 19, 2024 12:43
@standeren standeren marked this pull request as ready for review November 19, 2024 12:44
@TomasEng TomasEng self-assigned this Nov 22, 2024
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig fin størrelse på denne kodeendringen. Fortsett slik!

@TomasEng TomasEng removed their assignment Nov 22, 2024
@TomasEng TomasEng self-requested a review November 25, 2024 14:11
@standeren standeren force-pushed the 13949-possibility-to-edit-individual-code-lists-in-the-content-library branch from efd46f2 to f79119e Compare November 26, 2024 07:59
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Fungerer veldig fint!

Jeg la merke til to ting:

  • Av og til lugger det litt når man skriver. Men det vil nok bli fikset når feat: merge select and edit tabs in config #14137, som endrer lagring til onBlur , flettes inn i main.
  • Avsnitteksten i StudioCodeListEditor er ganske stor i forhold til overskriftene til akkordionene. Jeg tror det løses best ved å endre tekststørrelsen i StudioCodeListEditor fra medium til small.

Før

før

Etter

etter

@standeren
Copy link
Contributor Author

Test

Fungerer veldig fint!

Jeg la merke til to ting:

  • Av og til lugger det litt når man skriver. Men det vil nok bli fikset når feat: merge select and edit tabs in config #14137, som endrer lagring til onBlur , flettes inn i main.
  • Avsnitteksten i StudioCodeListEditor er ganske stor i forhold til overskriftene til akkordionene. Jeg tror det løses best ved å endre tekststørrelsen i StudioCodeListEditor fra medium til small.

Før

før

Etter

etter

Takk for testing 💯
Det stemmer at det kan lugge litt mens man skriver ja. Og som du sier er det gjort et bevisst valg å ignorere det til merge-saken er inne ettersom dette ikke er tilgjengelig enda uansett 🥳

Bra sett at det var størrelseforskjell på teksten - legger til size='small' i StudioParagraph når kodelisten er tom 👍

@standeren standeren merged commit 8329565 into main Dec 5, 2024
3 checks passed
@standeren standeren deleted the 13949-possibility-to-edit-individual-code-lists-in-the-content-library branch December 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to edit individual code lists in the content library
3 participants