Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove creat subfom buttom and show delete button just when it is a s… #14053

Merged

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Nov 13, 2024

Description

  • Removed the nytt underskjema button and its associated files.
  • Display the slett underskjema button only when the user navigates to the subform.
  • Updated tests accordingly.

Like this:

Screen.Recording.2024-11-14.at.09.08.10.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (eb8f613) to head (0ada1ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14053      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files        1775     1773       -2     
  Lines       23128    23097      -31     
  Branches     2685     2683       -2     
==========================================
- Hits        22047    22017      -30     
+ Misses        833      832       -1     
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JamalAlabdullah JamalAlabdullah changed the title remove creat subfom buttom and show delete button just when it is a s… feat: remove creat subfom buttom and show delete button just when it is a s… Nov 13, 2024
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @JamalAlabdullah 💪 🙂

I have some separated comments. And according to the video, can you fix so that the height will stay the same when delete button is displayed or not? 🙂

And there are some text resources that are no longer in use after you removed CreateSubformWrapper - remove them as well. Just control that they are not used somewhere else.

@JamalAlabdullah
Copy link
Contributor Author

Great work @JamalAlabdullah 💪 🙂

I have some separated comments. And according to the video, can you fix so that the height will stay the same when delete button is displayed or not? 🙂

And there are some text resources that are no longer in use after you removed CreateSubformWrapper - remove them as well. Just control that they are not used somewhere else.

Good catch 👍 I fixed the height and removed unused texts.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @JamalAlabdullah , one last comment :)

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev; looks good! ✅

@Jondyr Jondyr merged commit c811226 into main Nov 21, 2024
17 checks passed
@Jondyr Jondyr deleted the 14041-show-delete-subform-buttom-just-when-the-user-inside-a-subform branch November 21, 2024 09:38
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: Jamal Alabdullah <[email protected]>
Co-authored-by: Jonas Dyrlie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show "slette underskjema" buttom just when the user inside a subform
3 participants