-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove creat subfom buttom and show delete button just when it is a s… #14053
feat: remove creat subfom buttom and show delete button just when it is a s… #14053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14053 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 1775 1773 -2
Lines 23128 23097 -31
Branches 2685 2683 -2
==========================================
- Hits 22047 22017 -30
+ Misses 833 832 -1
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…he-user-inside-a-subform
…form-buttom-just-when-the-user-inside-a-subform
…ide-a-subform' of https://github.com/Altinn/altinn-studio into 14041-show-delete-subform-buttom-just-when-the-user-inside-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @JamalAlabdullah 💪 🙂
I have some separated comments. And according to the video, can you fix so that the height will stay the same when delete button is displayed or not? 🙂
And there are some text resources that are no longer in use after you removed CreateSubformWrapper - remove them as well. Just control that they are not used somewhere else.
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.test.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/Subform/SubformWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/Subform/DeleteSubformWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/Subform/DeleteSubformWrapper.tsx
Show resolved
Hide resolved
Good catch 👍 I fixed the height and removed unused texts. |
…he-user-inside-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @JamalAlabdullah , one last comment :)
frontend/packages/ux-editor/src/components/Elements/LayoutSetsContainer.test.tsx
Show resolved
Hide resolved
…ide-a-subform' of https://github.com/Altinn/altinn-studio into 14041-show-delete-subform-buttom-just-when-the-user-inside-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…he-user-inside-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev; looks good! ✅
Co-authored-by: Jamal Alabdullah <[email protected]> Co-authored-by: Jonas Dyrlie <[email protected]>
Description
nytt underskjema
button and its associated files.slett underskjema
button only when the user navigates to the subform.Like this:
Screen.Recording.2024-11-14.at.09.08.10.mov
Related Issue(s)
Verification
Documentation