Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: .net8 -> .net9 #14043

Merged
merged 7 commits into from
Nov 14, 2024
Merged

chore: .net8 -> .net9 #14043

merged 7 commits into from
Nov 14, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Nov 13, 2024 •
edited
Loading

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. skip-releasenotes Issues that do not make sense to list in our release notes backend labels Nov 13, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft November 13, 2024 09:01
@github-actions github-actions bot added kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. labels Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (43e8ffb) to head (dfb2e3b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14043   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files        1770     1770           
  Lines       23132    23132           
  Branches     2689     2689           
=======================================
  Hits        22034    22034           
  Misses        848      848           
  Partials      250      250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirkoSekulic mirkoSekulic marked this pull request as ready for review November 13, 2024 19:46
framitdavid
framitdavid approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

standeren
standeren approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirkoSekulic mirkoSekulic merged commit 9bda262 into main Nov 14, 2024
25 checks passed
@mirkoSekulic mirkoSekulic deleted the chore/dotnet9 branch November 14, 2024 08:02
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@mirkoSekulic @nkylstad
chore: .net8 -> .net9 (#14043)
c1f141b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standeren standeren standeren approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
backend kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Team Studio
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirkoSekulic @framitdavid @standeren