-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix error when editing component IDs #14021
fix: Fix error when editing component IDs #14021
Conversation
9a25778
to
aec5e49
Compare
aec5e49
to
4b6ccae
Compare
…ching-json-key-eg-id-type-datamodelbindings--is-also-updated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14021 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 1756 1756
Lines 22976 22976
Branches 2681 2681
=======================================
Hits 21877 21877
Misses 849 849
Partials 250 250 ☔ View full report in Codecov by Sentry. |
…ching-json-key-eg-id-type-datamodelbindings--is-also-updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting bug with a nice solution! Great work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ok in dev 👍
Description
This pull request fixes an error that occurs when using a property name (e.g.,
id
,type
,dataModelBindings
, ...) as a component id.Related Issue(s)
id
,type
,dataModelBindings
, ...) is also updated #14004Verification