Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error when editing component IDs #14021

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Nov 8, 2024

Description

This pull request fixes an error that occurs when using a property name (e.g., id, type, dataModelBindings, ...) as a component id.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 8, 2024
@mlqn mlqn force-pushed the 14004-when-a-component-id-is-updated-any-matching-json-key-eg-id-type-datamodelbindings--is-also-updated branch from 9a25778 to aec5e49 Compare November 11, 2024 10:50
@mlqn mlqn force-pushed the 14004-when-a-component-id-is-updated-any-matching-json-key-eg-id-type-datamodelbindings--is-also-updated branch from aec5e49 to 4b6ccae Compare November 11, 2024 10:52
mlqn added 2 commits November 11, 2024 15:23
…ching-json-key-eg-id-type-datamodelbindings--is-also-updated
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (bf7450c) to head (3343470).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14021   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1756     1756           
  Lines       22976    22976           
  Branches     2681     2681           
=======================================
  Hits        21877    21877           
  Misses        849      849           
  Partials      250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn marked this pull request as ready for review November 12, 2024 17:00
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug with a nice solution! Great work! 👍

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok in dev 👍

@JamalAlabdullah JamalAlabdullah merged commit cdfff3c into main Nov 14, 2024
17 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 14004-when-a-component-id-is-updated-any-matching-json-key-eg-id-type-datamodelbindings--is-also-updated branch November 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a component ID is updated, any matching JSON key (e.g., id, type, dataModelBindings, ...) is also updated
3 participants