-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove help text in FormComponentConfig #14012
base: main
Are you sure you want to change the base?
fix: remove help text in FormComponentConfig #14012
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14012 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 1740 1740
Lines 22815 22815
Branches 2670 2670
=======================================
Hits 21722 21722
Misses 847 847
Partials 246 246 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are still some places the questionmark/helptext is used, like in attachment for example. Are those also applicable to this issue?
What do you think @Ildest ?
Yes, the properties you can set, that have the question marks/help texts) change from component to component. I am working on #13982 to get an overview of that. Maybe @JamalAlabdullah can follow that issue and see which ones I have checked, and then remove from each of those components? |
Does this mean this issue will not be done before this list is also done? @Ildest |
@Jondyr This can be merged if everything is ok to make it easer to Gørild when working with the rest of the component list. And then we create a new issue for other component. here is the components covered by this issue: |
Yes @Jondyr, I think it should be blocked until all are checked. I am waiting for this to be approved an merged now, so I can continue checking. Hopefully, it should be quicker, since many standard help texts for properties will already be removed, and I only need to look for those components that have something extra. |
Description
(?)
in FormComponentConfigRelated Issue(s)
?
helptext that is generated in apps #13981Verification
Documentation