Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove help text in FormComponentConfig #14012

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Nov 8, 2024

Description

  • Removed help text (?) in FormComponentConfig

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Nov 8, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 8, 2024
@JamalAlabdullah JamalAlabdullah changed the title remove help text in FormComponentConfig fix: remove help text in FormComponentConfig Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (22337dc) to head (1240744).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14012   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1740     1740           
  Lines       22815    22815           
  Branches     2670     2670           
=======================================
  Hits        21722    21722           
  Misses        847      847           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some places the questionmark/helptext is used, like in attachment for example. Are those also applicable to this issue?

What do you think @Ildest ?

@Ildest
Copy link
Contributor

Ildest commented Nov 11, 2024

I think there are still some places the questionmark/helptext is used, like in attachment for example. Are those also applicable to this issue?

What do you think @Ildest ?

Yes, the properties you can set, that have the question marks/help texts) change from component to component. I am working on #13982 to get an overview of that. Maybe @JamalAlabdullah can follow that issue and see which ones I have checked, and then remove from each of those components?

@JamalAlabdullah
Copy link
Contributor Author

I think there are still some places the questionmark/helptext is used, like in attachment for example. Are those also applicable to this issue?

What do you think @Ildest ?

@Jondyr The helpText has now been removed from all the components checked in the list here: #13982.

@JamalAlabdullah JamalAlabdullah assigned Jondyr and unassigned Jondyr Nov 11, 2024
@Jondyr
Copy link
Member

Jondyr commented Nov 11, 2024

Maybe @JamalAlabdullah can follow that issue and see which ones I have checked, and then remove from each of those components?

Does this mean this issue will not be done before this list is also done? @Ildest
If so, maybe this should be moved to blocked until that list is completed? @JamalAlabdullah

@JamalAlabdullah
Copy link
Contributor Author

Maybe @JamalAlabdullah can follow that issue and see which ones I have checked, and then remove from each of those components?

Does this mean this issue will not be done before this list is also done? @Ildest If so, maybe this should be moved to blocked until that list is completed? @JamalAlabdullah

@Jondyr This can be merged if everything is ok to make it easer to Gørild when working with the rest of the component list. And then we create a new issue for other component. here is the components covered by this issue:
Screenshot 2024-11-12 at 09 40 35

@Ildest
Copy link
Contributor

Ildest commented Nov 12, 2024

Maybe @JamalAlabdullah can follow that issue and see which ones I have checked, and then remove from each of those components?

Does this mean this issue will not be done before this list is also done? @Ildest If so, maybe this should be moved to blocked until that list is completed? @JamalAlabdullah

Yes @Jondyr, I think it should be blocked until all are checked. I am waiting for this to be approved an merged now, so I can continue checking. Hopefully, it should be quicker, since many standard help texts for properties will already be removed, and I only need to look for those components that have something extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the ? helptext that is generated in apps
4 participants