-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subform): Automatically add closesubformbuttons #14009
feat(subform): Automatically add closesubformbuttons #14009
Conversation
backend/tests/Designer.Tests/EventHandlers/LayoutSetCreated/SubformCreatedHandlerTests.cs
Fixed
Show fixed
Hide fixed
…on-to-any-layout-created-in-a-subform
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14009 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 1763 1763
Lines 23000 23000
Branches 2676 2676
=======================================
Hits 21915 21915
Misses 836 836
Partials 249 249 ☔ View full report in Codecov by Sentry. |
…on-to-any-layout-created-in-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for me and it works fine, It would be nice if @mlqn can have a look also
I have also taken a look at it. It looks great. I will be so bold to move it to test. 😄 |
…on-to-any-layout-created-in-a-subform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev - works as expected :) Great work!
Co-authored-by: JamalAlabdullah <[email protected]> Co-authored-by: Lars <[email protected]>
Description
Screen.Recording.2024-11-07.154902.mp4
Related Issue(s)
closeSubformButton
to any layout created in a subform #13844Verification
Documentation