Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subform): Automatically add closesubformbuttons #14009

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Nov 7, 2024

Description

  • Added new MediatR handlers for subform layoutset & layout addition.
    • Uses a new AppDevelopmentService method for adding components to a layout, to add a closesubformbutton automatically when a new page for a subform is created
Screen.Recording.2024-11-07.154902.mp4

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr linked an issue Nov 7, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend labels Nov 7, 2024
@Jondyr Jondyr marked this pull request as ready for review November 7, 2024 14:47
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (4d8c7e3) to head (aa1afdc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14009   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files        1763     1763           
  Lines       23000    23000           
  Branches     2676     2676           
=======================================
  Hits        21915    21915           
  Misses        836      836           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me and it works fine, It would be nice if @mlqn can have a look also

@lassopicasso
Copy link
Contributor

lassopicasso commented Nov 14, 2024

It looks good for me and it works fine, It would be nice if @mlqn can have a look also

I have also taken a look at it. It looks great. I will be so bold to move it to test. 😄

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected :) Great work!

@lassopicasso lassopicasso merged commit fc5f892 into main Nov 14, 2024
24 checks passed
@lassopicasso lassopicasso deleted the 13844-automatically-add-the-closesubformbutton-to-any-layout-created-in-a-subform branch November 14, 2024 12:33
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically add the closeSubformButton to any layout created in a subform
3 participants