-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui-editor): ActionButton and CustomButton as valid children for ButtonGroup #13935
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13935 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 1699 1699
Lines 22490 22490
Branches 2633 2633
=======================================
Hits 21411 21411
Misses 833 833
Partials 246 246 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev 💯
Description
ActionButton and CustomButton are valid buttons and are valid as children of ButtonGroup. It should be allowed to add these button types to a ButtonGroup.
Verification