Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove react-modal dependency completely #13933

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 28, 2024

Description

  • Removing the dependency completly

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (4f52f21) to head (f918215).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13933   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1673           
  Lines       22189    22189           
  Branches     2608     2608           
=======================================
  Hits        21109    21109           
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wrt95 wrt95 merged commit d76a686 into main Oct 29, 2024
22 checks passed
@wrt95 wrt95 deleted the remove-react-modal-from-dependencies branch October 29, 2024 09:10
@JamalAlabdullah JamalAlabdullah removed their assignment Oct 29, 2024
@wrt95 wrt95 self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend kind/dependencies Used for issues or pull requests that are dependency updates skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants