Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use StudioContentMenu in ContentLibrary #13927

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Oct 28, 2024

Description

Skjermopptak.2024-10-30.kl.12.44.41.mov

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch from b8634ed to 3962016 Compare October 28, 2024 07:48
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 28, 2024
@standeren standeren changed the title Use StudioContentMenu in ContentLibrary feat: Use StudioContentMenu in ContentLibrary Oct 29, 2024
@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch 2 times, most recently from 422034d to 9fc28fc Compare October 30, 2024 07:19
@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch from 9fc28fc to 5ea5fcb Compare October 30, 2024 11:18
@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch 2 times, most recently from 8f077fc to 8fc476b Compare October 30, 2024 12:15
@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch from 8fc476b to 50025ce Compare October 30, 2024 12:37
@standeren standeren added team/studio-domain2 skip-releasenotes Issues that do not make sense to list in our release notes labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (fad4b91) to head (2fce3db).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13927   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files        1694     1697    +3     
  Lines       22445    22453    +8     
  Branches     2630     2628    -2     
=======================================
+ Hits        21366    21374    +8     
  Misses        834      834           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch from 87c96bf to 0178785 Compare October 30, 2024 14:38
@standeren standeren force-pushed the use-studio-content-menu-in-content-library branch from 0178785 to bcacb06 Compare October 30, 2024 14:40
@standeren standeren marked this pull request as ready for review October 31, 2024 06:03
@standeren standeren linked an issue Oct 31, 2024 that may be closed by this pull request
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Her var det ikke mye å pirke på, bare diverse småting. Bra jobbet!

@standeren standeren requested a review from TomasEng November 4, 2024 13:33
@standeren standeren assigned TomasEng and unassigned standeren Nov 5, 2024
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utmerket!

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test
Fungerer som det skal 😊

@ErlingHauan ErlingHauan merged commit 95a0859 into main Nov 6, 2024
16 checks passed
@ErlingHauan ErlingHauan deleted the use-studio-content-menu-in-content-library branch November 6, 2024 09:48
@ErlingHauan ErlingHauan removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create StudioContentMenu
3 participants