Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3615 add button for create new subform in nextrecommendedaction #13925

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Oct 27, 2024

Description

  • Added new buttom (Opprett et nytt skjema) inside the nextReccomendAction to add a new subform.
  • Added a new component called CreateNewLayoutSet for rendering a new StudioCard when the user clicks the buttom (Opprett et nytt skjema)
  • Save the new added subform to other subforms.
  • Added tests
  • NOTE: For this issue the new StudioCard includes just input for adding a new subform, and binding with datamodel will be fixed in this #13928
  • Here is the solution for now:
createNewSybform.mp4

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 27, 2024
@JamalAlabdullah JamalAlabdullah changed the title Feat13615 add button for create new subform in nextrecommendedaction Feat: 13615 add button for create new subform in nextrecommendedaction Oct 27, 2024
@JamalAlabdullah JamalAlabdullah changed the title Feat: 13615 add button for create new subform in nextrecommendedaction feat: 3615 add button for create new subform in nextrecommendedaction Oct 27, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (34fd4d4) to head (a9c93da).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...eNewSubformLayoutSet/CreateNewSubformLayoutSet.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13925   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1675    +2     
  Lines       22191    22220   +29     
  Branches     2609     2611    +2     
=======================================
+ Hits        21111    21139   +28     
- Misses        834      835    +1     
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Added some questions and suggestions for changes:

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected 🙂

@lassopicasso lassopicasso merged commit 378bf66 into main Oct 29, 2024
17 checks passed
@lassopicasso lassopicasso deleted the feat13615-add-button-for-create-new-subform-in-nextrecommendedaction branch October 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button for "create new subform layoutset" in NextRecommendedAction and saving
3 participants