-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 3615 add button for create new subform in nextrecommendedaction #13925
feat: 3615 add button for create new subform in nextrecommendedaction #13925
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13925 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 1673 1675 +2
Lines 22191 22220 +29
Branches 2609 2611 +2
=======================================
+ Hits 21111 21139 +28
- Misses 834 835 +1
Partials 246 246 ☔ View full report in Codecov by Sentry. |
…in-nextrecommendedaction
…mmendedaction' of https://github.com/Altinn/altinn-studio into feat13615-add-button-for-create-new-subform-in-nextrecommendedaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Added some questions and suggestions for changes:
...eader/EditLayoutSetForSubform/EditLayoutSet/CreateNewLayoutSet/CreateNewLayoutSet.module.css
Outdated
Show resolved
Hide resolved
...roperties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/CreateNewLayoutSet/index.ts
Outdated
Show resolved
Hide resolved
...mponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/EditLayoutSet.tsx
Outdated
Show resolved
Hide resolved
...mponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/EditLayoutSet.tsx
Outdated
Show resolved
Hide resolved
...ertiesHeader/EditLayoutSetForSubform/EditLayoutSet/CreateNewLayoutSet/CreateNewLayoutSet.tsx
Outdated
Show resolved
Hide resolved
...sHeader/EditLayoutSetForSubform/EditLayoutSet/CreateNewLayoutSet/CreateNewLayoutSet.test.tsx
Outdated
Show resolved
Hide resolved
...ponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSetForSubform.test.tsx
Outdated
Show resolved
Hide resolved
…in-nextrecommendedaction
…for-create-new-subform-in-nextrecommendedaction
…mmendedaction' of https://github.com/Altinn/altinn-studio into feat13615-add-button-for-create-new-subform-in-nextrecommendedaction
…in-nextrecommendedaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev - works as expected 🙂
Description
Opprett et nytt skjema
) inside thenextReccomendAction
to add a new subform.CreateNewLayoutSet
for rendering a newStudioCard
when the user clicks the buttom (Opprett et nytt skjema
)subform
to othersubforms
.StudioCard
includes just input for adding a newsubform
, and binding withdatamodel
will be fixed in this #13928createNewSybform.mp4
Related Issue(s)
Verification
Documentation