feat: Use StudioContentMenu in SettingsModal #13899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
standeren
changed the title
standeren
force-pushed
the
use-studio-content-menu-in-settings-modal
branch
from
5cea0ba to
d6215eb
Compare
standeren
added
team/studio-domain1
skip-releasenotes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13899 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 1702 1703 +1
Lines 22539 22543 +4
Branches 2642 2642
=======================================
+ Hits 21459 21463 +4
Misses 834 834
Partials 246 246 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
use-studio-content-menu-in-settings-modal
branch
5 times, most recently
from
ba80e2d to
179f6d5
Compare
standeren
force-pushed
the
use-studio-content-menu-in-settings-modal
branch
from
179f6d5 to
062b5a9
Compare
TomasEng
reviewed
Oct 30, 2024
...eHeader/SubHeader/SettingsModalButton/SettingsModal/hooks/useSettingsModalMenuTabConfigs.tsx
Show resolved
Hide resolved
3 tasks
Jondyr
requested changes
Nov 4, 2024
...eHeader/SubHeader/SettingsModalButton/SettingsModal/hooks/useSettingsModalMenuTabConfigs.tsx
Show resolved
Hide resolved
...-development/layout/PageHeader/SubHeader/SettingsModalButton/SettingsModal/SettingsModal.tsx
Outdated
Show resolved
Hide resolved
Jondyr
approved these changes
Nov 4, 2024
lassopicasso
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement StudioContentMenu in SettingsModal.
Settingsmodal
Old menu in settingsmodal:
New menu in settingsmodal:
Related Issue(s)
Verification