Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12787 resizable testing feedback changes #13154

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Jul 15, 2024

Description

Changes based on testing feedback:

  • Removed the hover effect on handles
  • Added a minimum size (250px) to center panels
  • Added flex-wrap: wrap to editgrid tabs and overflow-x: auto on property panels to prevent content overflow
  • Set the preview to open by default
  • Made collapsed panels persistent in local storage

Additional changes:

  • Added throttling to resizing to calculate new container sizes only once per render cycle.
    Renders taking longer than usual might have multiple mousemove events fired, resulting in the code trying to calculate new sizes for the elements before the last resizing operation finished. This overwrote the last calculation and caused a clunky dragging feel.
  • Minor code structure refactoring

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (1651068) to head (d7c2f3c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13154      +/-   ##
==========================================
- Coverage   92.16%   86.04%   -6.12%     
==========================================
  Files        1443       16    -1427     
  Lines       20302      473   -19829     
  Branches     2432       41    -2391     
==========================================
- Hits        18711      407   -18304     
+ Misses       1326       62    -1264     
+ Partials      265        4     -261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊
Good minimum size for the center columns 👍

@Jondyr Jondyr assigned Jondyr and standeren and unassigned Jondyr Jul 16, 2024
@Jondyr Jondyr force-pushed the 12787-resizable-testing-feedback-changes branch from 5b7fe18 to d8eef7c Compare July 16, 2024 07:40
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤩
Small comment on the grid tab only

@Jondyr Jondyr merged commit ede94f7 into main Jul 16, 2024
5 of 6 checks passed
@Jondyr Jondyr deleted the 12787-resizable-testing-feedback-changes branch July 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants