-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12787 resizable testing feedback changes #13154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13154 +/- ##
==========================================
- Coverage 92.16% 86.04% -6.12%
==========================================
Files 1443 16 -1427
Lines 20302 473 -19829
Branches 2432 41 -2391
==========================================
- Hits 18711 407 -18304
+ Misses 1326 62 -1264
+ Partials 265 4 -261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😊
Good minimum size for the center columns 👍
…l ref" This reverts commit 8685e3d.
5b7fe18
to
d8eef7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🤩
Small comment on the grid tab only
Description
Changes based on testing feedback:
flex-wrap: wrap
to editgrid tabs andoverflow-x: auto
on property panels to prevent content overflowAdditional changes:
Renders taking longer than usual might have multiple
mousemove
events fired, resulting in the code trying to calculate new sizes for the elements before the last resizing operation finished. This overwrote the last calculation and caused a clunky dragging feel.Related Issue(s)
Verification