Add payment component by default in addLayoutSet endpoint when adding a payment layoutset #13102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/process
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/AddLayoutSetTests.cs
Dismissed
Show dismissed
Hide dismissed
6 tasks
standeren
force-pushed
the
add-payment-component-by-default-when-adding-payment-task
branch
2 times, most recently
from
a21798b to
c47128a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13102 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 1426 1426
Lines 19957 19958 +1
Branches 2389 2389
=======================================
+ Hits 18338 18339 +1
Misses 1360 1360
Partials 259 259 ☔ View full report in Codecov by Sentry. |
lassopicasso
approved these changes
Jul 10, 2024
mirkoSekulic
requested changes
Jul 10, 2024
backend/src/Designer/Infrastructure/GitRepository/AltinnAppGitRepository.cs
Outdated
Show resolved
Hide resolved
… a payment layoutset
standeren
force-pushed
the
add-payment-component-by-default-when-adding-payment-task
branch
2 times, most recently
from
2d098f6 to
f34bd70
Compare
mirkoSekulic
approved these changes
Jul 11, 2024
standeren
force-pushed
the
add-payment-component-by-default-when-adding-payment-task
branch
from
f34bd70 to
751c2a9
Compare
standeren
deleted the
add-payment-component-by-default-when-adding-payment-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the taskType from frontend in addition to the actual layoutSetConfig when adding a task in the processEditor.
Check in the AddLayoutSet endpoint in backend if the taskType is
paymentand add a default component in the new default layout if so.Related Issue(s)
Verification