Add dataModelName parameter to GetModelMetadata endpoint #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2741-update-endpoint-fetching-datamodel
…thub.com/Altinn/altinn-studio into 12741-update-endpoint-fetching-datamodel
…DataTypeId_Is_NonExisting
github-actions
bot
added
solution/studio/designer
github-actions
bot
added
the
area/ui-editor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12826 +/- ##
=======================================
Coverage 90.65% 90.66%
=======================================
Files 1361 1361
Lines 19426 19426
Branches 2371 2371
=======================================
+ Hits 17611 17612 +1
+ Misses 1553 1552 -1
Partials 262 262 ☔ View full report in Codecov by Sentry. |
…thub.com/Altinn/altinn-studio into 12741-update-endpoint-fetching-datamodel
…thub.com/Altinn/altinn-studio into 12741-update-endpoint-fetching-datamodel
…thub.com/Altinn/altinn-studio into 12741-update-endpoint-fetching-datamodel
ErlingHauan
removed
area/ui-editor
standeren
requested changes
May 23, 2024
backend/src/Designer/Services/Implementation/AppDevelopmentService.cs
Outdated
Show resolved
Hide resolved
backend/src/Designer/Services/Interfaces/IAppDevelopmentService.cs
Outdated
Show resolved
Hide resolved
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetModelMetadataTests.cs
Outdated
Show resolved
Hide resolved
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetModelMetadataTests.cs
Show resolved
Hide resolved
frontend/packages/ux-editor-v3/src/components/config/EditFormComponent.test.tsx
Outdated
Show resolved
Hide resolved
...ckages/ux-editor/src/components/Properties/PageConfigPanel/HiddenExpressionOnLayout.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/EditFormComponent.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/ExpressionContent/ExpressionContent.test.tsx
Outdated
Show resolved
Hide resolved
…t-data-model' where applicable
github-actions
bot
added
area/ui-editor
standeren
reviewed
May 24, 2024
backend/src/Designer/Services/Implementation/AppDevelopmentService.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetModelMetadataTests.cs
Fixed
Show fixed
Hide fixed
standeren
reviewed
May 28, 2024
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Make route 'model-metadata' take optional parameter dataModelName * Add tests for dataModelName param * Update path in paths.js * Refactor arrange part of tests into a separate method * Add 'undefined' value for dataModelName where it is used in frontend code * Modify GetModelName method and delete unused code * Add fallback to ApplicationMetadata in GetModelName * Move layoutSetsMocks into a new file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
GetModelMetadataendpoint infers which data model to return based on thelayoutSetparameter. Now that we will support multiple data models per layout set, we have to be more specific when requesting the data model. Therefore, the optionaldataModelNameparameter has been added in this PR.If there is no
dataModelNameparameter specified in the request, then we are still returning the data model based on thelayoutSetparameter, ensuring backwards compatibility.Related Issue(s)
Verification
Documentation