Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ some bugs in attachmentList #12680

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

lassopicasso
Copy link
Contributor

Description

This PR fixes two bugs that I encountered after merging the following PR: #12067

  • Remove not supporting data type ids message
image
  • hide PDF selector in attachmentList when layout set does not have the task customReceipt
    PDF selector can only be generated in the app in this task.

Related Issue(s)

  • itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso added kind/bug Used when there is a defect / something is not working as it should. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. skip-releasenotes Issues that do not make sense to list in our release notes added-to-sprint labels Apr 18, 2024
@lassopicasso lassopicasso self-assigned this Apr 18, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (378e7e3) to head (c2cb9d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12680   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files        1296     1296           
  Lines       18553    18557    +4     
  Branches     2259     2261    +2     
=======================================
+ Hits        16729    16733    +4     
  Misses       1564     1564           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lassopicasso lassopicasso merged commit 43a6c92 into main Apr 19, 2024
10 checks passed
@lassopicasso lassopicasso deleted the remove-not-supporting-dataTypeIds-message branch April 19, 2024 05:40
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
* add dataTypeIds to customProperties

* hide PDF selector/switch when layout set is not customReceipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants