Fix dagl and regna bug in policy editor

[ghost]

Description

• Fixing the bug where both the code for dagl and regna was shown as well as the title for them.

Related Issue(s)

• Policy editor should support displaying roles with upper and lower case rolecodes #12080

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (60280e5) 86.41% compared to head (617775c) 86.42%.

Files	Patch %	Lines
...ents/ExpandablePolicyCard/ExpandablePolicyCard.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12247   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        1198     1198           
  Lines       18066    18075    +9     
  Branches     2292     2294    +2     
=======================================
+ Hits        15612    15621    +9     
  Misses       2168     2168           
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[framitdavid]

Great work! 🚀 Just some comments to consider. 😊

[nkylstad]

I see that these changes may help avoid that we display existing roles in the list of available roles to add.
However, they don't seem to solve the problem described in the linked issue, which is that apps with rolecodes that are in uppercase, have the roles displayed with the rolecode rather than the display text for the role 🤔

[ghost]

I see that these changes may help avoid that we display existing roles in the list of available roles to add. However, they don't seem to solve the problem described in the linked issue, which is that apps with rolecodes that are in uppercase, have the roles displayed with the rolecode rather than the display text for the role 🤔

@nkylstad, That is true, but I'm unsure if that is the case for any roles at the moment? 🤔
The reason it looked like it before this PR was that the DAGL and REGNA roles were added by default when creating a new app, and then the list was merged with the list of roles options. When looking through the list locally now, I cannot see any roles displayed as you mention.
It might be that I misunderstand this, but I believe it should work as expected now 😄

[nkylstad]

@nkylstad, That is true, but I'm unsure if that is the case for any roles at the moment? 🤔

The screenshot in the issue is from a real case in production where a user has noted that they used to see the role name, but now they just see the role code. F.ex. rule 2 in https://altinn.studio/editor/skd/rf-1551/overview has this issue.

I assume the problem is that some of the roles in that particular policy have uppercase rolecodes (which are allowed), but when we get the role display name we don't handle this.

[ghost]

@nkylstad, That is true, but I'm unsure if that is the case for any roles at the moment? 🤔

The screenshot in the issue is from a real case in production where a user has noted that they used to see the role name, but now they just see the role code. F.ex. rule 2 in https://altinn.studio/editor/skd/rf-1551/overview has this issue.

I assume the problem is that some of the roles in that particular policy have uppercase rolecodes (which are allowed), but when we get the role display name we don't handle this.

Se der ja! Jeg skal få sett på det 😄

[ghost]

@nkylstad, da skal problemet være løst og fikset 😄

[nkylstad]

Nice! 🥇