Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CreateApp): Code cleanup and make the CreateAppForm accessible #11496

Merged
merged 20 commits into from
Nov 24, 2023

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Nov 3, 2023

Description

This pull request (PR) addresses issue #11475 and has undergone code refactoring to enhance readability and improve the accessibility of the feature.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Nov 3, 2023
@framitdavid framitdavid changed the title Feat/clean up create app on dashboard feat(CreateApp): fixed overflow issue, code cleanup and make the feature accessible Nov 3, 2023
@framitdavid framitdavid changed the title feat(CreateApp): fixed overflow issue, code cleanup and make the feature accessible feat(CreateApp): Code cleanup and make the CreateApp form accessible Nov 7, 2023
@framitdavid framitdavid self-assigned this Nov 7, 2023
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. labels Nov 15, 2023
@framitdavid framitdavid marked this pull request as ready for review November 15, 2023 13:38
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3ef5edc) 83.70% compared to head (9271e17) 83.70%.
Report is 3 commits behind head on master.

Files Patch % Lines
...nd/dashboard/pages/CreateService/CreateService.tsx 94.28% 0 Missing and 2 partials ⚠️
...ents/ServiceOwnerSelector/ServiceOwnerSelector.tsx 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11496   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         883      885    +2     
  Lines       13052    13050    -2     
  Branches     1711     1712    +1     
=======================================
- Hits        10925    10924    -1     
+ Misses       1868     1866    -2     
- Partials      259      260    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid changed the title feat(CreateApp): Code cleanup and make the CreateApp form accessible feat(CreateApp): Code cleanup and make the CreateAppForm accessible Nov 20, 2023
@TomasEng TomasEng self-assigned this Nov 22, 2023
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fremragende arbeid. Dette ble mye ryddigere! Har bare noen forslag til den nye hooken.

@TomasEng TomasEng assigned framitdavid and unassigned TomasEng Nov 22, 2023
@framitdavid framitdavid merged commit dce309c into master Nov 24, 2023
9 checks passed
@framitdavid framitdavid deleted the feat/cleanUpCreateAppOnDashboard branch November 24, 2023 07:33
@framitdavid framitdavid removed their assignment Nov 24, 2023
@nkylstad
Copy link
Member

Result looks good in dev! Moving to "Done"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants