Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the implementations of Next Recommended Action for Tabell for underskjema #13999

Closed
JamalAlabdullah opened this issue Nov 6, 2024 · 2 comments · Fixed by #14032
Closed
Labels
added-to-sprint frontend kind/feature-request Feature request that will be considered. team/studio-domain2 text/content used for issues that need som text improvements, often by ux

Comments

@JamalAlabdullah
Copy link
Contributor

JamalAlabdullah commented Nov 6, 2024

Description

We need to change a little bit in the user story regarding creating a new subform, here is the changes we need after feedback from UX:
https://github.com/orgs/Altinn/projects/36/views/3?filterQuery=sprint%3A%40current+label%3A%22team%2Fstudio-domain2%22&pane=issue&itemId=84996085&issue=Altinn%7Caltinn-studio%7C13928

Additional Information

No response

@JamalAlabdullah JamalAlabdullah added the kind/feature-request Feature request that will be considered. label Nov 6, 2024
@JamalAlabdullah JamalAlabdullah added added-to-sprint team/studio-domain2 text/content used for issues that need som text improvements, often by ux frontend labels Nov 6, 2024
@JamalAlabdullah JamalAlabdullah moved this to 📈 Todo in Team Studio Nov 6, 2024
@lassopicasso lassopicasso self-assigned this Nov 7, 2024
@lassopicasso
Copy link
Contributor

lassopicasso commented Nov 7, 2024

Following discussions with @Annikenkbrathen, the tasks for this issue are:

  • Remove buttons below the selector. ✅
  • In the next recommended action (displayed when the "Tabell for underskjema" component is initially added), display the "Create new subform" link below the selector. ✅
  • When clicking "Create new subform," replace the selector and link with a new card. ✅
  • The new card should include Save and Close buttons (if closed, return to the selector to allow selecting an existing subform). ✅
  • After creating a new subform, stay in the current configuration view instead of redirecting to the new subform ✅
  • Replace "Det finnes ingen sidegrupper i løsningen som kan brukes som et underskjema" with the next recommended action shown in Anniken's comment in feat/add data model binding for subfrom #13928. ✅
  • Rename the "til utforming"-button to "Utform underskjemaet" ✅

@lassopicasso lassopicasso linked a pull request Nov 11, 2024 that will close this issue
4 tasks
@lassopicasso lassopicasso assigned Jondyr and unassigned lassopicasso Nov 14, 2024
@lassopicasso lassopicasso moved this from 👷 In Progress to 🔎 Review in Team Studio Nov 14, 2024
@Jondyr Jondyr assigned lassopicasso and unassigned Jondyr Nov 14, 2024
@lassopicasso lassopicasso added skip-documentation Issues where updating documentation is not relevant and removed skip-documentation Issues where updating documentation is not relevant labels Nov 15, 2024
@lassopicasso lassopicasso moved this from 🔎 Review to 🧪 Test in Team Studio Nov 15, 2024
@lassopicasso lassopicasso removed their assignment Nov 15, 2024
@lassopicasso lassopicasso changed the title adjust the implementations when creating new subform adjust the implementations of Next Recommended Action Nov 18, 2024
@lassopicasso lassopicasso changed the title adjust the implementations of Next Recommended Action adjust the implementations of Next Recommended Action for Tabell for underskjema Nov 18, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Nov 18, 2024
@JamalAlabdullah
Copy link
Contributor Author

tested ok in dev 👍

@JamalAlabdullah JamalAlabdullah removed their assignment Nov 18, 2024
@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint frontend kind/feature-request Feature request that will be considered. team/studio-domain2 text/content used for issues that need som text improvements, often by ux
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants