Support link a sub-form to data model

[framitdavid]

We need to be able to configure which data model a subform should use. Should this be configured directly in the subform component, or through the layout set configuration?

[nkylstad]

According to the documentation, this is done via the layout-set. That being said, we could still tie it to the config of the subform component in our UI, as one of the "required" configs. I believe we have talked about moving the creation of a subform layoutset into the flow of adding/configuring the subform component - datatype could be a part of that.
We could even provide an option to create a new data model directly from that config. Some possible flows:

• Add subform component --> Create new subform layoutset --> Create datamodel/type to associate with the subform layoutset
• Add subform component --> Create new subform layoutset --> Connect subform layoutset to existing data model
• Add subform component --> Connect to existing subform layoutset

[framitdavid]

Add subform component --> Create new subform layoutset --> Create datamodel/type to associate with the subform layoutset

I liked the first bullet point. In addition to that, should the user have the option to change which data model/type is referenced from the settings on the layout set itself? @nkylstad

There might be some validations concerns by allowing editing the data model reference...

[nkylstad]

I think we should consider supporting all 3 flows. i.e. starting with nothing, starting with an existing data model, and starting with a ready configured layoutset, incl. datamodel,
I suppose there may be more flows to consider as well, but these 3 seem to be a good starting point.

I liked the first bullet point. In addition to that, should the user have the option to change which data model/type is referenced from the >settings on the layout set itself? @nkylstad

There might be some validations concerns by allowing editing the data model reference...

Yep, I think we should keep it simple, and say that all config related to subform has to be done via the subform component. You can edit the contents of the data model, and layouts f.ex., but not really swap it out with anything else.
Any major changes should probably result in having to set up a new subform component imo.

@Annikenkbrathen probably has some thoughts here as well 😊

[framitdavid]

I think we should consider supporting all 3 flows. i.e. starting with nothing, starting with an existing data model, and starting with a ready configured layoutset, incl. datamodel, I suppose there may be more flows to consider as well, but these 3 seem to be a good starting point.

I liked the first bullet point. In addition to that, should the user have the option to change which data model/type is referenced from the >settings on the layout set itself? @nkylstad
There might be some validations concerns by allowing editing the data model reference...

Yep, I think we should keep it simple, and say that all config related to subform has to be done via the subform component. You can edit the contents of the data model, and layouts f.ex., but not really swap it out with anything else. Any major changes should probably result in having to set up a new subform component imo.

@Annikenkbrathen probably has some thoughts here as well 😊

Yes, I agree with that! 👍

[Annikenkbrathen]

I agree with your points, Nina! I think that when adding a subform to the subform component, the user should be able to choose between an existing subform or setting up a new one. I also believe it should be possible for the user to change between existing subforms chosen in the component, but they should not be able to edit the subform itself further, such as by changing the data model.

So essentially, we support adding or creating subforms and changing which one to use in the component, but not editing them. This is something we could consider handling on the layout set for the subform, but not within the component itself.

I made some sketches for connecting a data model to the subform.

I'm still missing a sketch for creating a new data model when creating a new subform.Do you have any thoughts on the GUI here?

1. A blank data model will be created that can be edited later on the Data Model page.

2. The user will be linked to the Data Model page to create it there and then have to find the subform component later to continue setting it up.
   The second option could be difficult for the user because it makes it hard to get an overview of what needs to be set up first (before they can configure the component) and where they should do it.

[Annikenkbrathen]

Maybe something like this?

[wrt95]

If no data model connected --> Enable dropdown to select data model and have the "Lag ny datamodell" button.
Else --> Have the dropdown disabled, and show the "Navn på datamodell" view textfield (disabled) with the data model.

[JamalAlabdullah]

we should wait for this #13999

[Jondyr]

Tested in dev, noticed two issues:

• deleting subformlayouts created with a new datamodel gives a toast error message and layout does not seem to be deleted
• creating two subformlayouts and making a new datamodel with the same name for both seems to work but does not create a new datamodel for the second subform, and shows a toast error message

[lassopicasso]

Tested in dev, noticed two issues:

• deleting subformlayouts created with a new datamodel gives a toast error message and layout does not seem to be deleted
• creating two subformlayouts and making a new datamodel with the same name for both seems to work but does not create a new datamodel for the second subform, and shows a toast error message

@Jondyr
I indirectly mention these issues at the end of the description to the PR, Remaining Tasks, but I should have been more explicit. 🙂

1. It will be handled by this issue, I see Andrea is working on it. :) The reason for the error message, is that it doesn't find the id in app metadata file.
2. The subtask of this issue, implement validation, will solve this issue were you can't create a datamodel with a name that already exists :)

[Jondyr]

@lassopicasso
That's my fault, I did not read that section of the PR, which I clearly should have done 😄
#14138 tested ok and merged ✅