remove unneccessary code and add test

Altinn · Feb 6, 2024 · 51f026b · 51f026b
1 parent d5beeaa
commit 51f026b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx b/frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx
@@ -45,6 +45,23 @@ jest.mock('./Calculations', () => ({
 jest.mock('react-i18next', () => ({ useTranslation: () => mockUseTranslation(texts) }));
 
 describe('Properties', () => {
+  describe('Text', () => {
+    it('Toggles text when clicked', async () => {
+      render();
+      const button = screen.queryByRole('button', { name: textText });
+      await act(() => user.click(button));
+      expect(button).toHaveAttribute('aria-expanded', 'true');
+      await act(() => user.click(button));
+      expect(button).toHaveAttribute('aria-expanded', 'false');
+    });
+
+    it('Opens text when a component is selected', async () => {
+      const { rerender } = render();
+      rerender(getComponent({ formId: 'test' }));
+      const button = screen.queryByRole('button', { name: textText });
+      await waitFor(() => expect(button).toHaveAttribute('aria-expanded', 'true'));
+    });
+  });
   describe('Content', () => {
     it('Closes content on load', () => {
       render();
@@ -60,13 +77,6 @@ describe('Properties', () => {
       await act(() => user.click(button));
       expect(button).toHaveAttribute('aria-expanded', 'false');
     });
-
-    it('Opens text when a component is selected', async () => {
-      const { rerender } = render();
-      rerender(getComponent({ formId: 'test' }));
-      const button = screen.queryByRole('button', { name: textText });
-      await waitFor(() => expect(button).toHaveAttribute('aria-expanded', 'true'));
-    });
   });
 
   describe('Dynamics', () => {

diff --git a/frontend/packages/ux-editor/src/components/config/editModal/EditTextResourceBindings.tsx b/frontend/packages/ux-editor/src/components/config/editModal/EditTextResourceBindings.tsx
@@ -20,20 +20,13 @@ export const EditTextResourceBindings = ({
   handleComponentChange,
   textResourceBindingKeys,
 }: EditTextResourceBindingsProps) => {
-  const handleRemoveKey = (key: string) => {
-    const updatedComponent = { ...component };
-    delete updatedComponent.textResourceBindings[key];
-    handleComponentChange(updatedComponent);
-  };
-
   return (
     <div className={classes.container}>
       {textResourceBindingKeys.map((key: string) => (
         <EditTextResourceBinding
           key={key}
           component={component}
           handleComponentChange={handleComponentChange}
-          removeTextResourceBinding={() => handleRemoveKey(key)}
           textKey={key}
           labelKey={`ux_editor.modal_properties_textResourceBindings_${key}` as any}
           placeholderKey={`ux_editor.modal_properties_textResourceBindings_${key}_add` as any}