fix test and add return types for hooks

frontend/libs/studio-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/CodeListsActionsBar/CodeListsActionsBar.test.tsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { screen } from '@testing-library/react';
-
 import { textMock } from '@studio/testing/mocks/i18nMock';
 import { CodeListsActionsBar } from './CodeListsActionsBar';
 import userEvent from '@testing-library/user-event';
@@ -43,44 +42,54 @@ describe('CodeListsActionsBar', () => {
   it('does not call onUploadCodeList when uploading a file with existing file name', async () => {
     const user = userEvent.setup();
     renderCodeListsActionsBar();
-    const fileUploaderButton = screen.getByLabelText(
-      textMock('app_content_library.code_lists.upload_code_list'),
-    );
-    const file = new File(['test'], `${codeListName1}.json`, { type: 'application/json' });
-    await user.upload(fileUploaderButton, file);
+    await uploadFileWithExistingFileName(user);
     expect(onUploadCodeListMock).not.toHaveBeenCalled();
   });
 
   it('renders correct toast error message when uploading a file with existing file name', async () => {
     const user = userEvent.setup();
     renderCodeListsActionsBar();
-    const fileUploaderButton = screen.getByLabelText(
-      textMock('app_content_library.code_lists.upload_code_list'),
-    );
-    const file = new File(['test'], `${codeListName1}.json`, { type: 'application/json' });
-    await user.upload(fileUploaderButton, file);
+    await uploadFileWithExistingFileName(user);
     const toastErrorText = screen.getByText(
       textMock('validation_errors.upload_file_name_occupied'),
     );
     expect(toastErrorText).toBeInTheDocument();
   });
 
-  it('renders correct toast error message when uploading a file with empty name', async () => {
+  it('does not call onUploadCodeList when uploading a file with empty name', async () => {
     const user = userEvent.setup();
     renderCodeListsActionsBar();
-    const fileUploaderButton = screen.getByLabelText(
-      textMock('app_content_library.code_lists.upload_code_list'),
-    );
-    const file = new File(['test'], '.json', { type: 'application/json' });
-    await user.upload(fileUploaderButton, file);
+    await uploadFileWithEmptyFileName(user);
     expect(onUploadCodeListMock).not.toHaveBeenCalled();
+  });
+
+  it('renders correct toast error message when uploading a file with empty name', async () => {
+    const user = userEvent.setup();
+    renderCodeListsActionsBar();
+    await uploadFileWithEmptyFileName(user);
     const toastErrorText = screen.getByText(
       textMock('validation_errors.upload_file_name_required'),
     );
     expect(toastErrorText).toBeInTheDocument();
   });
 });
 
+const uploadFileWithExistingFileName = async (user: UserEvent) => {
+  const fileUploaderButton = screen.getByLabelText(
+    textMock('app_content_library.code_lists.upload_code_list'),
+  );
+  const file = new File(['test'], `${codeListName1}.json`, { type: 'application/json' });
+  await user.upload(fileUploaderButton, file);
+};
+
+const uploadFileWithEmptyFileName = async (user: UserEvent) => {
+  const fileUploaderButton = screen.getByLabelText(
+    textMock('app_content_library.code_lists.upload_code_list'),
+  );
+  const file = new File(['test'], '.json', { type: 'application/json' });
+  await user.upload(fileUploaderButton, file);
+};
+
 const renderCodeListsActionsBar = () => {
   renderWithProviders(
     <CodeListsActionsBar

frontend/libs/studio-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/hooks/useInputCodeListNameErrorMessage.ts

@@ -1,7 +1,7 @@
 import { FileNameErrorResult } from '@studio/pure-functions';
 import { useTranslation } from 'react-i18next';
 
-export function useInputCodeListNameErrorMessage() {
+export function useInputCodeListNameErrorMessage(): (fileNameError: FileNameErrorResult) => string {
   const { t } = useTranslation();
 
   type FileNameInputErrorResult = Exclude<FileNameErrorResult, FileNameErrorResult.NoRegExMatch>;

frontend/libs/studio-content-library/src/ContentLibrary/LibraryBody/pages/CodeList/hooks/useUploadCodeListNameErrorMessage.ts

@@ -1,7 +1,9 @@
 import { FileNameErrorResult } from '@studio/pure-functions';
 import { useTranslation } from 'react-i18next';
 
-export function useUploadCodeListNameErrorMessage() {
+export function useUploadCodeListNameErrorMessage(): (
+  fileNameError: FileNameErrorResult,
+) => string {
   const { t } = useTranslation();
 
   type FileNameUploadErrorResult = Exclude<FileNameErrorResult, FileNameErrorResult.NoRegExMatch>;